Skip to content

feat: change ATOF time window to -5,5#458

Merged
Sangbaek merged 1 commit intomainfrom
atof-window-26
Apr 3, 2026
Merged

feat: change ATOF time window to -5,5#458
Sangbaek merged 1 commit intomainfrom
atof-window-26

Conversation

@zhiwanxu
Copy link
Copy Markdown
Collaborator

@zhiwanxu zhiwanxu commented Apr 3, 2026

With the new CJ version, our ATOF time window is now (-5,5).
We changed the following:

  • Move the ATOF histogram range to (-5,5), previously was at (83,95)
  • Removed the .abs() from f1.getParameter(1) to include peaks at negative.

Copy link
Copy Markdown
Collaborator

@Sangbaek Sangbaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sorry that there was absolute value on the mean earlier.

@Sangbaek
Copy link
Copy Markdown
Collaborator

Sangbaek commented Apr 3, 2026

@c-dilks
Could you format the pr name and merge this PR? It looks straightforward to me and I don't see any problem.

@Sangbaek Sangbaek added the rg-l PR for Run Group L label Apr 3, 2026
@Sangbaek Sangbaek changed the title Fix issue #454: change ATOF time window to -5,5 feat: change ATOF time window to -5,5 Apr 3, 2026
@Sangbaek
Copy link
Copy Markdown
Collaborator

Sangbaek commented Apr 3, 2026

@c-dilks Could you format the pr name and merge this PR? It looks straightforward to me and I don't see any problem.

I just suggest to merge this now.

Closes #454

@Sangbaek Sangbaek merged commit baff078 into main Apr 3, 2026
9 checks passed
@Sangbaek Sangbaek deleted the atof-window-26 branch April 3, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rg-l PR for Run Group L

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants